Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Utilities for text height behavior #495

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Oct 2, 2024

Description

before

$text.textHeightBehavior(
   const TextHeightBehavior(
      applyHeightToFirstAscent: false,
      applyHeightToLastDescent: false,
    ),
)

now

$text.chain
    ..textHeightBehavior.heightToFirstAscent(false),
    ..textHeightBehavior.heightToLastDescent(false),
)

Changes

  • Create a utility for this TextHeightBehavior and TextLeadingDistribution
  • Reorganize scalar_util_test.dart file

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 4:50pm

@tilucasoli tilucasoli requested a review from leoafarias October 2, 2024 16:23
@github-actions github-actions bot added the mix label Oct 2, 2024
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 49063ec into main Oct 17, 2024
6 checks passed
@leoafarias leoafarias deleted the feat/utilities-for-text-height-behavior branch October 17, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants